feat(nextjs): Add method and url to route handler request data #14084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
onurtemizkan
force-pushed
the
onur/nextjs-route-handler-requestdata
branch
from
4cd8e8d to
b7d1eed
Compare
onurtemizkan
force-pushed
the
onur/nextjs-route-handler-requestdata
branch
from
b7d1eed to
0659e96
Compare
lforst
reviewed
Oct 29, 2024
| @@ -60,6 +60,9 @@ test('Should record exceptions and transactions for faulty route handlers', asyn | |||
|
|
|||
| expect(routehandlerError.exception?.values?.[0].value).toBe('route-handler-error'); | |||
|
|
|||
| expect(routehandlerError.request?.method).toBe('PUT'); | |||
| expect(routehandlerError.request?.url).toContain('/route-handlers/[param]/error'); | |||
There was a problem hiding this comment.
I think what we really need here is the unparameterized url. Which is a major pain in the butt to grab in Next.js because it turns static routes dynamic 🤔 Let me sit on this a bit.
lforst
approved these changes
Oct 29, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #13908