fix(nextjs): Respect directives in value injection loader #14083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
approved these changes
Oct 28, 2024
| const SKIP_COMMENT_AND_DIRECTIVE_REGEX = | ||
| // Note: CodeQL complains that this regex potentially has n^2 runtime. This likely won't affect realistic files. | ||
| // biome-ignore lint/nursery/useRegexLiterals: No user input | ||
| new RegExp('^(?:\\s*|/\\*(?:.|\\r|\\n)*?\\*/|//.*[\\n\\r])*(?:"[^"]*";|\'[^\']*\';)?'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for turbopack (#8105).
In the future,
sentry.client.config.tswill likely need to be configured with a"use client"directive so that turbopack knows it needs to be treated as a file on the client.Our value injection loader currently always prepends the
sentry.client.config.tsfile with statements, rendering any directives in the file useless and crashing turbopack when the file is attempted to be imported somewhere.This PR detects any comments and directives on top of a file to only inject values after.