Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling-node): Always warn when running on incompatible major version of Node.js #14043

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Oct 21, 2024

This seems important enough to warn about each time regardless of debug build

Fixes: #14015

@lforst lforst changed the title fix(profiling) always warn when running on incompatible major version… fix(profiling): Always warn when running on incompatible major version… Oct 21, 2024
@lforst lforst changed the title fix(profiling): Always warn when running on incompatible major version… fix(profiling-node): Always warn when running on incompatible major version… Oct 21, 2024
@lforst lforst changed the title fix(profiling-node): Always warn when running on incompatible major version… fix(profiling-node): Always warn when running on incompatible major version Oct 21, 2024
@lforst lforst changed the title fix(profiling-node): Always warn when running on incompatible major version fix(profiling-node): Always warn when running on incompatible major version of Node.js Oct 21, 2024
@JonasBa JonasBa enabled auto-merge (squash) October 21, 2024 15:09
@JonasBa JonasBa merged commit cfd411e into develop Oct 28, 2024
60 of 61 checks passed
@JonasBa JonasBa deleted the jb/profiling/version-warning branch October 28, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on init within a docker container - fix: warn about Node ABI version
2 participants