-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(replay): Ensure replay_id
is removed from frozen DSC when stopped
#13893
Conversation
size-limit report 📦
|
replay_id
is removed from frozen DSCreplay_id
is removed from frozen DSC when replay ends
replay_id
is removed from frozen DSC when replay endsreplay_id
is removed from frozen DSC when stopped
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When a replay is stopped (for whatever reason), we want to ensure to remove the
replay_id
from the DSC.This can be in two places:
We just reset it on both.
Closes #13872