-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Expose suppressTracing
API
#13875
Conversation
Hey, I think this makes sense to me - thank you! Could you also export it from browser? This should probably go into browser/src/exports.ts, unless it increases bundle size noticeably 🤔 But should probably be fine. Also note that you'll have to re-export this from all the node-downstream SDKs like next, remix, astro, ... |
The method should be all exported. There's only a few that I have to add, otherwise most of the libraries just rely on each other's export. |
The export is still missing in astro, aws-serverless and bun - FYI there is an E2E test that checks this here: /~https://github.com/getsentry/sentry-javascript/actions/runs/11270583037/job/31342004007?pr=13875 :) |
That should do it! I somehow missed over those libraries, and I couldn't get |
suppressTracing
API
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13875 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13875 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>
suppressTracing
seems to be only accessible via@sentry/core
at the moment. Since there isn't any additional work needed to get this working on Node (and possibly Deno), I just exposed it directly within the SDK. For other SDK, I cannot confirm if it's the same; thus, no changes are made there.