-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): Ensure wrap()
only returns functions
#13838
Conversation
size-limit report 📦
|
wrap()
only returns functions
@legobeat for sure. Thanks for bringing it up. |
…ort) (#13864) Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
@lforst is it possible please for this to also be backported to v6? Or would it be too much work, unnecessary? Just wondering because it would make our lives easier to not have to upgrade, since v6 comes with a bundle and we don't have bundling setup ourselves just yet =) |
@henrahmagix good point! We discussed this internally and concluded that we will not backport the change to v6. Part of the decision was that this was technically a weakness, not a vulnerability. We think v6 is too old to justify any change. I encourage you to upgrade. I will also note that we have no strict policy for which versions receive security fixes. Generally the latest major will receive fixes, for versions before that we will decide on a case-per-case basis. |
__sentry_wrapped__
may be overwritten by libraries, causing subsequent code to crash if the new value is not a function.