Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(core): Rename release management plugin name #647

Merged
merged 2 commits into from
Jan 8, 2025
Merged

ref(core): Rename release management plugin name #647

merged 2 commits into from
Jan 8, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 8, 2025 •
edited
Loading

  • Renames the release management plugin name from sentry-debug-id-upload-plugin to sentry-release-management-plugin
  • adds simple tests to catch renamings/regressions since they have a potential effect on SDKs like @sentry/sveltekit

lforst
lforst approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting PR description 😄 - otherwise lgtm

@Lms24 Lms24 self-assigned this Jan 8, 2025
@Lms24 Lms24 enabled auto-merge (squash) January 8, 2025 11:02
@Lms24 Lms24 merged commit d051b07 into main Jan 8, 2025
18 checks passed
@Lms24 Lms24 deleted the lms/fix-release-management-plugin-name branch January 8, 2025 11:04
@Lms24 Lms24 mentioned this pull request Jan 8, 2025
Merged
Lms24 added a commit to getsentry/sentry-javascript that referenced this pull request Jan 9, 2025
@Lms24
fix(sveltekit): Ensure source maps deletion is called after source ma…
6779dfe 
…ps upload (#14942)

- replace the original release management plugin with a custom one
where we start release creation on `closeBundle`
- replace the original file deletion plugin with a custom one where we
start deletion on `closeBundle`
- in both cases, further ensuresthat the plugin is only invoked for
build and as late as possible (`enforce: 'post'`). 
- searche for the release management plugin by its old and new name
introduced in
getsentry/sentry-javascript-bundler-plugins#647
- slightly rename the custom source maps uploading plugin for better
convention; as well as some variables for better readability
- add unit tests for the new custom sub plugins
Lms24 added a commit to getsentry/sentry-javascript that referenced this pull request Jan 9, 2025
@Lms24
fix(sveltekit): Ensure source maps deletion is called after source ma…
3e7100c 
…ps upload (#14942)

- replace the original release management plugin with a custom one
where we start release creation on `closeBundle`
- replace the original file deletion plugin with a custom one where we
start deletion on `closeBundle`
- in both cases, further ensuresthat the plugin is only invoked for
build and as late as possible (`enforce: 'post'`). 
- searche for the release management plugin by its old and new name
introduced in
getsentry/sentry-javascript-bundler-plugins#647
- slightly rename the custom source maps uploading plugin for better
convention; as well as some variables for better readability
- add unit tests for the new custom sub plugins
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 11, 2025
@renovate
Update dependency @sentry/vite-plugin to v2.23.0
a0b32ab 
| datasource | package             | from   | to     |
| ---------- | ------------------- | ------ | ------ |
| npm        | @sentry/vite-plugin | 2.22.7 | 2.23.0 |


## [v2.23.0](/~https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2230)

-   chore(deps): bump nanoid from 3.3.6 to 3.3.8 ([#641](getsentry/sentry-javascript-bundler-plugins#641))
-   feat(core): Detect Railway release name ([#639](getsentry/sentry-javascript-bundler-plugins#639))
-   feat(core): Write module injections to `globalThis` ([#636](getsentry/sentry-javascript-bundler-plugins#636))
-   feat(react-component-annotate): Allow skipping annotations on specified components ([#617](getsentry/sentry-javascript-bundler-plugins#617))
-   ref(core): Rename release management plugin name ([#647](getsentry/sentry-javascript-bundler-plugins#647))

Work in this release contributed by [@conor-ob](/~https://github.com/conor-ob). Thank you for your contribution!
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 11, 2025
@renovate
Update dependency @sentry/vite-plugin to v2.23.0
bb02428 
| datasource | package             | from   | to     |
| ---------- | ------------------- | ------ | ------ |
| npm        | @sentry/vite-plugin | 2.22.7 | 2.23.0 |


## [v2.23.0](/~https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2230)

-   chore(deps): bump nanoid from 3.3.6 to 3.3.8 ([#641](getsentry/sentry-javascript-bundler-plugins#641))
-   feat(core): Detect Railway release name ([#639](getsentry/sentry-javascript-bundler-plugins#639))
-   feat(core): Write module injections to `globalThis` ([#636](getsentry/sentry-javascript-bundler-plugins#636))
-   feat(react-component-annotate): Allow skipping annotations on specified components ([#617](getsentry/sentry-javascript-bundler-plugins#617))
-   ref(core): Rename release management plugin name ([#647](getsentry/sentry-javascript-bundler-plugins#647))

Work in this release contributed by [@conor-ob](/~https://github.com/conor-ob). Thank you for your contribution!
@Lms24 Lms24 mentioned this pull request Jan 13, 2025
Merged
@Lms24 Lms24 mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @lforst