Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HubProvider functionality for logrus integration #936

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Dec 22, 2024

Resolves #513

@ribice ribice requested a review from cleptric December 22, 2024 10:47
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (e1d804e) to head (b861481).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
logrus/logrusentry.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   83.70%   83.61%   -0.09%     
==========================================
  Files          49       49              
  Lines        5129     5133       +4     
==========================================
- Hits         4293     4292       -1     
- Misses        680      684       +4     
- Partials      156      157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ribice
Copy link
Collaborator Author

ribice commented Dec 30, 2024

The only thing failing here is the coverage (81% instead of 83%). Do I have to 'fix' it or we can merge as-is?

@cleptric
Copy link
Member

cleptric commented Jan 2, 2025

Do we have docs for this?

@cleptric cleptric merged commit 066c69e into master Jan 2, 2025
15 of 16 checks passed
@cleptric cleptric deleted the logrus-improvements branch January 2, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add goroutine support in logrus implementation
2 participants