Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request): Add Proxy-Authorization as a sensitive header #859

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jonathroth
Copy link
Contributor

No description provided.

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did these values show up in the Sentry UI, or did server-side scrubbing redact them?

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (00f7f6c) to head (b96f906).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files          52       52           
  Lines        4626     4626           
=======================================
  Hits         3804     3804           
  Misses        669      669           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathroth
Copy link
Contributor Author

Thanks! Did these values show up in the Sentry UI, or did server-side scrubbing redact them?

I was debugging the SDK locally and noticed this value would be passed to Sentry. I haven't checked anything against the UI or server side yet, but the SDK shouldn't send this sensitive value to the server when PII is disabled

@cleptric
Copy link
Member

cleptric commented Jul 18, 2024

Yes, I just wanted to also make sure our scrubbers work correctly in this case.

@cleptric cleptric merged commit ec57183 into getsentry:master Jul 18, 2024
21 checks passed
@jonathroth jonathroth deleted the proxy-auth-sensitive-header branch July 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants