Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI component class: support non-pre-defined props #6929

Merged
merged 2 commits into from
Jan 23, 2025
Merged

UI component class: support non-pre-defined props #6929

merged 2 commits into from
Jan 23, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 22, 2025 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • UI component classes (component, button, view button) now can accept props/blueprint options in addition that weren't defined in the PHP class. This allows e.g. to pass options from blueprint to a custom view button Vue component without the need for a custom PHP class.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

@distantnative distantnative added this to the 5.0.0-beta.3 milestone Jan 22, 2025
@distantnative distantnative self-assigned this Jan 22, 2025
@distantnative distantnative linked an issue Jan 22, 2025 that may be closed by this pull request
UI classes: support extra attrs property to loop through custom props #6927
Closed
@distantnative distantnative mentioned this pull request Jan 22, 2025
Merged
@distantnative distantnative force-pushed the v5/refactor/ui-component-attrs-2 branch from a2d20b1 to 7f98bd7 Compare January 22, 2025 15:46
@distantnative distantnative marked this pull request as ready for review January 22, 2025 20:02
@bastianallgeier bastianallgeier merged commit c24b672 into v5/develop Jan 23, 2025
12 checks passed
@bastianallgeier bastianallgeier deleted the v5/refactor/ui-component-attrs-2 branch January 23, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
5.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

UI classes: support extra attrs property to loop through custom props
2 participants
@distantnative @bastianallgeier