Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link field: improve invalid option handling #6919

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Link field: improve invalid option handling #6919

merged 2 commits into from
Jan 20, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 18, 2025 •
edited
Loading

Description

Summary of changes

  • JS code is more forgiving for invalid options (get ignored)
  • PHP validates provided options against available options and throws error if an invalid option gets passed

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.6.0 milestone Jan 18, 2025
@distantnative distantnative requested review from a team January 18, 2025 09:12
@distantnative distantnative self-assigned this Jan 18, 2025
@distantnative distantnative linked an issue Jan 18, 2025 that may be closed by this pull request
Link field should display proper errors #6731
Closed
@distantnative distantnative merged commit 2113ee6 into develop-minor Jan 20, 2025
16 of 17 checks passed
@distantnative distantnative deleted the fix/6731-link-field-unsupported-option branch January 20, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbora afbora afbora approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Link field should display proper errors
2 participants
@distantnative @afbora