Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block options: fix tabbing from sort handle #6893

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Block options: fix tabbing from sort handle #6893

merged 1 commit into from
Jan 13, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Calling event.preventDefault() on any key would prevent tab to work
  • Now only preventing those keys that we handle ourselves (up and down arrows)

Changelog

Fixes

  • Blocks: fixed keyboard navigation for sort handle

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.6.0 milestone Jan 11, 2025
@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative distantnative linked an issue Jan 11, 2025 that may be closed by this pull request
[4.1.0] Blocks field: keyboard navigation gets stuck on drag button #6240
Closed
@distantnative distantnative requested a review from a team January 11, 2025 11:46
bastianallgeier
bastianallgeier approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I've run into the bug myself a couple times and always wanted to add an issue for it but forgot to do so.

@bastianallgeier bastianallgeier merged commit 896bb69 into develop-minor Jan 13, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6240-block-options-tab-sort-handle branch January 13, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

[4.1.0] Blocks field: keyboard navigation gets stuck on drag button
2 participants
@distantnative @bastianallgeier