Access permissions 5: DRY permission caching #6881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Merge first
Description
Summary of changes
Move caching of
access
andlist
permissions toModelPermissions
Reasoning
DRY code, especially now that we would add five more of these methods to the
User
,Site
andLanguage
classesAdditional context
We could cache all other permissions as well, but I've wrestled with unit tests for too long before Christmas. The write permissions would also benefit less from the caching as there is usually only one write operation per request (in contrast to potentially hundreds of list/access permission checks).
Another advantage of the separate
canFromCache()
method is that it makes explicit which checks come from cache and which are dynamic. If we ever usecanFromCache()
in a place that needs dynamic checking, we will immediately be able to tell because of theLogicException
that is thrown then.The new
UserPermissions::cacheKey()
is currently uncovered as theUser
class does not haveaccess
/list
permissions at the moment. This will be fixed in the PR 7.Changelog
Refactoring
access
andlist
permissions per permission category, model type and user role to reduce code duplicationBreaking changes
None
Docs
None
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)