Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup codec based on real live STAC catalog #179

Merged
merged 13 commits into from
Nov 7, 2019

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Nov 6, 2019

Overview

Some fields here were required, even though pystac doesn't think it needs to write them. It's not important who's right from the perspective of having something demoable tomorrow, so I'm making them optional as I discover that they're missing. For the non-required strings it's probably correct that they're not there. For the non-required lists, it's a bit of a nuisance that the spec doesn't just say they're required, so we wouldn't have to deal with the empty list vs null semantics for the thousandth time. 🤷‍♂️

Also there's a weird STAC thing where bboxes are just bbox: [a, b, c, d] on stac items, but are {"spatial": {"bbox": [ [a, b, c, d]]}} in collections, so I had to mess with encoding / decoding / case classes a bit.

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Testing Instructions

  • serdespec

Copy link

@notthatbreezy notthatbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should definitely debrief after the sprint and figure out what our priorities are with the library to help us help our future selves more.

@jisantuc jisantuc merged commit 362e95f into geotrellis:develop Nov 7, 2019
@jisantuc jisantuc deleted the feature/js/codec-fixes branch November 7, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants