Fixup codec based on real live STAC catalog #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some fields here were required, even though pystac doesn't think it needs to write them. It's not important who's right from the perspective of having something demoable tomorrow, so I'm making them optional as I discover that they're missing. For the non-required strings it's probably correct that they're not there. For the non-required lists, it's a bit of a nuisance that the spec doesn't just say they're required, so we wouldn't have to deal with the empty list vs
null
semantics for the thousandth time. 🤷♂️Also there's a weird STAC thing where bboxes are just
bbox: [a, b, c, d]
on stac items, but are{"spatial": {"bbox": [ [a, b, c, d]]}}
in collections, so I had to mess with encoding / decoding / case classes a bit.Checklist
Testing Instructions