Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fillOpacity support for the markSymbolizer geostyler object #621

Merged
merged 10 commits into from
Dec 13, 2022

Conversation

pragmaeuge
Copy link
Contributor

Description

Hi, I have developed a simple mechanism for the support of the fillOpacity property in the markSymbolizer

Related issues or pull requests

At the moment, the "fillOpacity" of the markSymbolizer object is not supported. From now on, the "fillOpacity" property can be used to set the opacity property in the OpenLayer fill style characterization. However, the markSymbolizer "opacity" has the highest priority.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@jansule
Copy link
Contributor

jansule commented Oct 10, 2022

Thanks @pragmaeuge

Could you clean up your commit history, so that only the relevant commits are included in this PR?

@KaiVolland
Copy link
Contributor

@jansule we can squash and merge this commit to cleanup the history

@KaiVolland KaiVolland merged commit 391cd76 into geostyler:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants