-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write GraphicFill for PolygonSymbolizer #388
Write GraphicFill for PolygonSymbolizer #388
Conversation
1489813
to
1a78ff4
Compare
1a78ff4
to
a1e996a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Not sure if you want to resolve the commented TODOs before merging.
Please also check if geostyler-style
still has to be transformed for jest.
Co-authored-by: Evaldas <naujikas.evaldas@gmail.com>
Thanks for the reviews @KaiVolland @nevaldas! Regarding the TODOs: I would rather keep them for now, as we have to check if we actually run into performance issues somewhere. For now, I would say it is ok as is. |
We are using this already in our solution (yeah, we needed this ASAP). And the issue we had was that if image is not loaded when this code is executing, the |
Moved the discussion to issue #434 |
Description
This introduces the support for writing GraphicFill as part of a FillSymbolizer.
The main work was done by @rdewit in #244. I mainly did some minor refactorings and added tests.
Also, we now set the CanvasPattern directly as the color for the fill property, instead of using a custom renderer. Thereby we eliminate the z-index issue.
Please note that the common FillSymbolizer properties will have no effect, when using GraphicFill. This however is in line with the behavior in GeoServer.
Related issues or pull requests
Replaces #244
Solves #240
Solves #228
Pull request type
Please check the type of change your PR introduces:
Do you introduce a breaking change?
Checklist
npm test
locally)