Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse lineDash null as undefined #210

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Parse lineDash null as undefined #210

merged 1 commit into from
Dec 18, 2019

Conversation

jansule
Copy link
Contributor

@jansule jansule commented Nov 11, 2019

If no lineDash was defined in an openlayers Stroke it will be set to null by default. This leads to errors in the UI as defaultProps will not be used on null values.

To have a consistent handling ol-parser checks now if lineDash is null and sets it to undefined.

@jansule jansule requested a review from KaiVolland November 11, 2019 10:37
@jansule jansule merged commit b163c17 into geostyler:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVolland KaiVolland KaiVolland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jansule @KaiVolland