Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrintProviderField to work with textboxes #364

Merged
merged 1 commit into from
Sep 20, 2015

Conversation

geographika
Copy link
Member

With associated test. See issue #363

@chrismayer
Copy link
Contributor

Hi @geographika,
thanks a lot for your contribution. For me this looks very good. But I would like to have a second opinion on this. Maybe @weskamm or @marcjansen can have quick look?

@marcjansen
Copy link
Member

his looks good to me, @geographika and @chrismayer. I may have asked earlier, but do we have the CLA from you @geographika?

@chrismayer
Copy link
Contributor

I wrote him yesterday because of the CLA topic. Answer outstanding.

@chrismayer
Copy link
Contributor

The signed CLA of @geographika has been sent to the PSC.

So I this is good to go. Thanks again for your contribution @geographika! I will merge this now.

chrismayer added a commit that referenced this pull request Sep 20, 2015
Fix PrintProviderField to work with textboxes
@chrismayer chrismayer merged commit 1a33319 into geoext:master Sep 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants