Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added license and some updates - #minor #44

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Jan 19, 2022

No description provided.

By default all our services are public under BSD license.

Updated to python 3.9 and make sure to always starts with the latest
packages version.
@ltshb ltshb requested a review from boecklic January 19, 2022 05:46
@github-actions github-actions bot changed the title Added license and some updates Added license and some updates - #minor Jan 19, 2022
Copy link

@boecklic boecklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app/settings.py Outdated
if WSGI_WORKERS <= 0:
from multiprocessing import cpu_count
WSGI_WORKERS = (cpu_count() * 2) + 1
WSGI_TIMEOUT = int(os.getenv('WSGI_TIMEOUT', '30'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we aim for a lower timeout in general? Setting 30s as default seems high...

buildspec.yml Outdated
@@ -29,7 +29,7 @@ phases:
export GITHUB_BRANCH=${GITHUB_BRANCH#remotes/origin/};
fi
- export GITHUB_COMMIT=$(echo $CODEBUILD_RESOLVED_SOURCE_VERSION | cut -c 1-7)
- export GITHUB_TAG="$(git describe --tags 2>/dev/null)"
- export GITHUB_TAG="$(git describe --tags || echo 'no version info')"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be machine friendly, i.e. without spaces?

@ltshb ltshb merged commit c3017f5 into master Jan 19, 2022
@ltshb ltshb deleted the feat-license-and-updates branch January 19, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants