Moving allowed domain settings to infra #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
reviewed
Oct 21, 2021
app/settings.py
Outdated
| @@ -8,3 +8,7 @@ | |||
| os.environ['LOGS_DIR'] = LOGS_DIR # Set default if not set | |||
| LOGGING_CFG = os.getenv('LOGGING_CFG', 'logging-cfg-local.yml') | |||
| TRAP_HTTP_EXCEPTIONS = True | |||
|
|
|||
| # Definition of the allowed domains for CORS implementation | |||
| ALLOWED_DOMAINS_STRING = os.getenv('ALLOWED_DOMAINS', r'http[s]?://localhost') | |||
There was a problem hiding this comment.
I would either use '.*' as default or no default at all.
There was a problem hiding this comment.
yep good point, I've removed the default value (it comes through the .env.local file anyway)
Allow localhost domain by default (if nothing is set, so on local dev machines)
pakb
force-pushed
the
shift_config_to_infra
branch
from
4abe38b to
638975c
Compare
ltshb
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow localhost domain by default (if nothing is set, so on local dev machines)