Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-2520: Consolidate logging #49

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Aug 12, 2022

Updated the logging-utilities library and the local logging configuration.

The new local logging configuration requires the latest features of the
logging-utilities; ignore_missing. The local configuration reflect the one
that we will use for all our services on all staging.

@ltshb ltshb added WIP and removed feature labels Aug 12, 2022
@ltshb ltshb marked this pull request as draft August 12, 2022 12:46
@ltshb ltshb force-pushed the feat-BGDIINF_SB-2520-log-consolidation branch from 843e25f to 458e140 Compare August 15, 2022 11:53
@ltshb ltshb force-pushed the feat-BGDIINF_SB-2520-log-consolidation branch from 458e140 to b74f0f5 Compare August 15, 2022 13:42
@ltshb ltshb marked this pull request as ready for review August 15, 2022 13:42
@ltshb ltshb removed the WIP label Aug 15, 2022
@ltshb ltshb requested review from hansmannj and ltkum August 15, 2022 13:42
@ltshb ltshb force-pushed the feat-BGDIINF_SB-2520-log-consolidation branch from b74f0f5 to 05154c8 Compare August 15, 2022 13:44
Updated the logging-utilities library and the local logging configuration.

The new local logging configuration requires the latest features of the
logging-utilities; `ignore_missing`. The local configuration reflect the one
that we will use for all our services on all staging.
@ltshb ltshb force-pushed the feat-BGDIINF_SB-2520-log-consolidation branch from 05154c8 to 3316398 Compare August 15, 2022 13:53
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🥇

@ltshb ltshb merged commit 931992e into develop Aug 16, 2022
@ltshb ltshb deleted the feat-BGDIINF_SB-2520-log-consolidation branch August 16, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants