BGDIINF_SB-2163: Fixed CI branch name resolution #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed old hack for branch name resolution. This hack did not work with PR from fork as well as by some PR from dependabot. Use the newest Codebuild variable instead and make sure that the branch name used in docker tag don't contains `/` by replacing them to `_` (`/` is not allowed in docker tag name). For this replacement we need bash so make sure that Codebuild use bash instead of the default hash.
rebert
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old hack for branch name resolution. This hack did not work with
PR from fork as well as by some PR from dependabot.
Use the newest Codebuild variable instead and make sure that the branch
name used in docker tag don't contains
/by replacing them to_(
/is not allowed in docker tag name). For this replacement we needbash so make sure that Codebuild use bash instead of the default hash.