Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal view improvements #256

Closed
jollino opened this issue Jan 28, 2020 · 3 comments
Closed

Terminal view improvements #256

jollino opened this issue Jan 28, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@jollino
Copy link

jollino commented Jan 28, 2020

When using the landscape view, landscape mode is great to see full lines, but it also means seeing fewer of them.

Compare:
IMG_4003

and:
IMG_4003

The keyboard makes things worse:
IMG_4069

It would be nice if the app could "make room" to see more text, e.g. by hiding the tab bar below.
Even the update switch could be moved to the settings or removed entirely, in my humble opinion: I can't think of a single use case where you'd be in the terminal view without the terminal itself being updated...

@gdombiak
Copy link
Owner

Thanks Daniele for more great feedback. I do use the stop refreshing feature. :) What do you think if I switched the orders of those 2 fields. Comando GCode will appear first so that will give more room for the drop down. I will post a screenshot with that change before deciding adding logic to hide the numbers bar. Sounds good?

@gdombiak gdombiak added this to the 3.1 milestone Jan 28, 2020
@jollino
Copy link
Author

jollino commented Jan 28, 2020

I admit I never tried disabling it, I'll have to see what it does. :D
That would definitely help with the dropdown, in fact I was thinking about maybe having a separate button for the dropdown (maybe to the very right of the field, especially if the Send button is removed in favor of just pressing enter on the keyboard): tapping that button would show/hide the dropdown and, if needed, hide the keyboard.
It would also have the side effect of being able to type in the field freely without having the dropdown hide anything, even in portrait mode.
Not sure if that makes sense though, it's probably a lot of work for a very narrow use case.

On a side note, I noticed a few little things about the Italian translation that could be improved; I'll message you on FB with them. Did you happen to try any of those localization platforms, by the way?

@gdombiak
Copy link
Owner

Thanks so much Daniele. I haven't had time to check out those localizations tools. :( Will do as time allows.

Thanks,
Gaston

@gdombiak gdombiak added the enhancement New feature or request label Jan 28, 2020
gdombiak added a commit that referenced this issue Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants