Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license typo in ToNullTest #291

Closed
t92549 opened this issue Oct 18, 2022 · 2 comments · Fixed by #292
Closed

Fix license typo in ToNullTest #291

t92549 opened this issue Oct 18, 2022 · 2 comments · Fixed by #292
Labels
bug Confirmed or suspected bug good first issue Small, lower complexity and doesn't require pre-existing Koryphe knowledge
Milestone
v2.5.0

Comments

@t92549
Copy link
Contributor

t92549 commented Oct 18, 2022

koryphe/core/src/test/java/uk/gov/gchq/koryphe/impl/function/ToNullTest.java

Lines 1 to 5 in 152f8a9

package uk.gov.gchq.koryphe.impl.function;/*
* Copyright 2018-2020 Crown Copyright
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.

In ToNullTest the package line comes before the license rather than after, like the other files
@t92549 t92549 added bug Confirmed or suspected bug good first issue Small, lower complexity and doesn't require pre-existing Koryphe knowledge hacktoberfest labels Oct 18, 2022
@t92549 t92549 added this to the v2.5.0 milestone Oct 18, 2022
@GCHQDeveloper314
Copy link
Member

Making any change to this file will cause spotless to pick up on this. Running it with different settings will allow it to suggest the correction I think.

ElhilaliYassine added a commit to ElhilaliYassine/koryphe that referenced this issue Oct 18, 2022
@ElhilaliYassine
gchqgh-291:Fix license typo in ToNullTest
057293d
@ismacarbo
Copy link

gg

@t92549 t92549 linked a pull request Oct 18, 2022 that will close this issue
gh-291:Fix license typo in ToNullTest #292
Merged
t92549 added a commit to ElhilaliYassine/koryphe that referenced this issue Oct 18, 2022
@t92549
Merge branch 'develop' into gchqgh-291
7b0d0f3
t92549 added a commit that referenced this issue Oct 19, 2022
@ElhilaliYassine @GCHQDeveloper314 @t92549
gh-291:Fix license typo in ToNullTest (#292)
4dcc2e2 
* gh-291:Fix license typo in ToNullTest

* Update ToNullTest.java

Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed or suspected bug good first issue Small, lower complexity and doesn't require pre-existing Koryphe knowledge
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

gh-291:Fix license typo in ToNullTest ElhilaliYassine/koryphe
3 participants
@t92549 @ismacarbo @GCHQDeveloper314