ValidatePackageInfo: suppress Print output if requested
#5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ValidatePackageInfo` is called programmatically by the PackageManager package. In this situation, we do not want to show the diagnostic output.
ThomasBreuer
added
kind: enhancement
fingolfin
approved these changes
Jul 24, 2024
fingolfin
reviewed
Jul 24, 2024
lib/package.gd
Outdated
| @@ -1065,6 +1065,8 @@ DeclareGlobalFunction( "DeclareAutoreadableVariables" ); | |||
| ## The result is <K>true</K> if the record or the contents of the file, | |||
| ## respectively, has correct format, and <K>false</K> otherwise; | |||
| ## in the latter case information about the incorrect components is printed. | |||
| ## These diagnostic messages can be suppressed by setting the global option | |||
| ## <C>verbose</C> to <K>false</K>. | |||
There was a problem hiding this comment.
Hmm, how about
Suggested change
| ## <C>verbose</C> to <K>false</K>. | |
| ## <C>quiet</C> to <K>true</K>. |
as we already have a quiet option for a couple other commands.
Plus this allows writing
ValidatePackageInfo(rec() : quiet);
fingolfin
approved these changes
Jul 29, 2024
fingolfin
changed the title
ValidatePackageInfo: suppress Print output if wantedValidatePackageInfo: suppress Print output if requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidatePackageInfois called programmatically by the PackageManager package.In this situation, we do not want to show the diagnostic output.