Tell Sylow subgroups of natural An or Sn their size when we make them #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add another pre-computed Size (centralizers) and fix a test.
stevelinton
force-pushed
the
siz-syl-sn
branch
from
01e166b to
c33d7a1
Compare
|
I have now checked gpprmsya.gi and there are no more obvious places where a Size was easily calculated but not set. |
|
Looks good for merging |
hulpke
added a commit
that referenced
this pull request
Jan 31, 2016
Tell Sylow subgroups of natural An or Sn their size when they are created. This will save on a stab chain verification that can be costly for larger degrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves a stab chain verification, which is relatively expensive. This removes the calculation being considered in #499 almost completely, but the issue there probably applies to many other stab chain verifications.
The same thing could probably be done in a lot of other methods in the same file, and possibly even more generally, although beware the issue we once had in GL where computing the order even using the formula took longer than writing down the group, just because of the integer arithmetic.
In this case the order was being computed anyway in the SylowSubgroup methods.