Mark as obsolete: ZeroSM
/ZeroAttr
, AdditiveInverseSM
/AdditiveInverseAttr
OneSM
/OneAttr
, InverseSM
/InverseAttr
, TransposedMatAttr
#5263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have these three variants of
One
, together with a bunch of synonyms for each:OneImmutable
==One
==OneAttr
==Identity
OneMutable
==OneOp
OneSameMutability
==OneSM
This is then repeated for
Zero
,Inverse
,AdditiveInverse
.The delegation between these is already complicated enough, but each time I have to look into this, my head starts spinning due to the many synonyms, and I can't quite remember which is which. I propose we narrow this down a bit:
the variants with
SM
seems to be purely to avoid some typing, so I've removed all uses of them. Turns out no packages uses it, either. So we can mark them as obsolete.the
Attr
variants are also almost unused, except for a single use in the FinInG package (removed in FinInG 1.5.4). Still, we can safely mark it as obsolete, and remove all users of it beyond the documentation. (As a bonus, also makeTransposedMatAttr
obsolete.)the
Op
synonym to me also seems redundant. Alas, a ton of packages use them, so I mostly left those alone.I think it is fine to keep
One
(andIdentity
) as synonyms forOneImmutable
; at least for me personally it seems I can deal with that one synonym sufficiently well in my head.Please provide a short summary of this PR and its purpose here. E.g., does it add a new feature, and which? Does it fix a bug, and which? If there is an associated issue, please list it here.
Text for release notes
We track noteworthy changes as entries in the
CHANGES.md
file in the root directory of this repository. To help us decide whether and how to describe your PR, please do one of the following:CHANGES.md
, and write "see title" here (or if you have the required permissions, add the labelrelease notes: use title
to this PR and remove this section)Further details
If necessary, provide further details down here.