Speed up AlgebraicExtension and AlgebraicExtensionNC for larger degrees
#4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an algebraic extension K[X]/(f(X)), say of degree n, then GAP precomputes the reduced representatives of X^i, n <= i <= 2n-2, modulo f(X). With this patch this is done in n-2 row operations instead of (n-1)*(n-2)/2. This yields a significant speedup already for moderate degrees.
frankluebeck
added
backport-to-4.11-DONE
topic: library
topic: performance
hulpke
approved these changes
Jul 28, 2021
fingolfin
reviewed
Jul 29, 2021
fingolfin
changed the title
AlgebraicExtension and AlgebraicExtensionNC for larger degrees
fingolfin
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an algebraic extension K[X]/(f(X)), say of degree n,
then GAP precomputes the reduced representatives of X^i, n <= i <= 2n-2,
modulo f(X). With this patch this is done in n-2 row operations instead
of (n-1)*(n-2)/2. This yields a significant speedup already for moderate
degrees.
Text for release notes
'AlgebraicExtension(NC)' is now faster for larger degrees.