Enhance FreeGroup to support the option generatorNames to prescribe the names of the generators
#4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
kind: enhancement
hulpke
force-pushed
the
additions
branch
3 times, most recently
from
597b59f to
0a4226d
Compare
hulpke
changed the title
hulpke
force-pushed
the
additions
branch
2 times, most recently
from
0b73c87 to
b01d245
Compare
fingolfin
reviewed
Sep 28, 2020
Comment on lines
+315
to
317
| the result of <C>SylowSubgroup( <A>G</A>, <A>prime</A> )</C> | ||
| is a group with parent group | ||
| <A>G</A>. |
There was a problem hiding this comment.
Optional (but IMHO makes the XML more readable)
Suggested change
| the result of <C>SylowSubgroup( <A>G</A>, <A>prime</A> )</C> | |
| is a group with parent group | |
| <A>G</A>. | |
| the result of <C>SylowSubgroup( <A>G</A>, <A>prime</A> )</C> | |
| is a group with parent group <A>G</A>. |
Comment on lines
+344
to
346
| primitivity test above, point 113 would have been a fixed point | ||
| (and the | ||
| action would not even have been transitive). |
There was a problem hiding this comment.
Optional
Suggested change
| primitivity test above, point 113 would have been a fixed point | |
| (and the | |
| action would not even have been transitive). | |
| primitivity test above, point 113 would have been a fixed point | |
| (and the action would not even have been transitive). |
Addressed all issues from gap-system#4112 apart from adding full definitions in sections 6.1 and 6.2 Made example more stable by forcing the first orbit to be a set.
fingolfin
changed the title
generatorNames to allow changing the names of the generators of a group being constructed
ThomasBreuer
changed the title
generatorNames to allow changing the names of the generators of a group being constructedFreeGroup, support the option generatorNames to prescribe the names of the generators.
ThomasBreuer
added
release notes: added
fingolfin
changed the title
FreeGroup, support the option generatorNames to prescribe the names of the generators.FreeGroup to support the option generatorNames to prescribe the names of the generators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced an option that allows to change the names of the free group generators through an intermediate function.
Also some manual fix for the tutorial.