Document IsRangeRep and improve the documentation of ConvertToRangeRep, IsRange, and the section Ranges
#3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiccha
added
kind: enhancement
fingolfin
requested changes
May 24, 2019
ssiccha
force-pushed
the
ss/doc-IsRangeRep
branch
from
552d0c5 to
93a9ca2
Compare
Done |
Codecov Report
@@ Coverage Diff @@
## master #3472 +/- ##
==========================================
+ Coverage 80.47% 85.34% +4.87%
==========================================
Files 696 699 +3
Lines 343497 346902 +3405
==========================================
+ Hits 276413 296077 +19664
+ Misses 67084 50825 -16259
|
ssiccha
force-pushed
the
ss/doc-IsRangeRep
branch
from
93a9ca2 to
591e538
Compare
wilfwilson
requested changes
Jun 5, 2019
There was a problem hiding this comment.
I think this in good shape. I agree with @fingolfin that the 'will' should be changed to 'may'. I suggested a different way of changing the language of this line, in my opinion it improves things.
wilfwilson
reviewed
Jun 24, 2019
ssiccha
force-pushed
the
ss/doc-IsRangeRep
branch
2 times, most recently
from
66f9c84 to
3c3275c
Compare
|
I just pushed the newest version. |
wilfwilson
approved these changes
Jun 24, 2019
... `ConvertToRangeRep`, `IsRange`, and the section `Ranges`
Documents `IsRangeRep`.
Restructures the `ConvertToRangeRep` documentation:
- remove some redundant statements
- move some explanations to the `IsRangeRep` doc
- The documentation previously specified that an object in `IsRangeRep`
*is* converted into a plain list if a value is assigned to one of its
entries. This is changed to say that in this case the representation
*may* be changed.
Adds examples to `IsRange` and the info that assigning to a range turns
it into a plain list.
Improves the example in the introduction of the `Ranges` section,
ssiccha
force-pushed
the
ss/doc-IsRangeRep
branch
from
3c3275c to
cae9e01
Compare
|
Rebased onto master. |
fingolfin
approved these changes
Jun 27, 2019
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents
IsRangeRep.Restructures
ConvertToRangeRep:IsRangeRepdocAdds examples to
IsRangeand the info that assigning to a range turns itinto a plain list.
Improves the example in the introduction of the
Rangessection,