-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'PrintObj(1.)' #3395
Fix 'PrintObj(1.)' #3395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with these changes.
However, deleting a library function is potentially dangerous. We should check if no distributed package uses it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! However, I have some remarks that ought to be addressed.
For the record, I verified that no distributed package is using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, actually meant to "request changes", not "approve"... Anyway, those changes apparently already are in the works, thanks
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
==========================================
- Coverage 85.16% 85.15% -0.02%
==========================================
Files 697 697
Lines 344056 344050 -6
==========================================
- Hits 293003 292960 -43
- Misses 51053 51090 +37
|
Deletes old hack DOTTIFY
Add Max' comments
@fingolfin I think I addressed all your comments. |
Fixes #3369 .
I received help for this PR from @sebasguts and @fingolfin