Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TmpNameAllArchs instead of TmpName #3326

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Use TmpNameAllArchs instead of TmpName #3326

merged 1 commit into from
Mar 6, 2019

Conversation

olexandr-konovalov
Copy link
Member

@olexandr-konovalov olexandr-konovalov commented Mar 5, 2019 •
edited
Loading

Otherwise, TmpName produces a non-existing path on Windows.
Closes #3309

Use TmpNameAllArchs instead of TmpName
c1fb2d4 
Otherwise, TmpName produces a non-existing path on Windows.
Closes gap-system#3309
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 85.075% when pulling c1fb2d4 on alex-konovalov:fix-streams-test into 843bc10 on gap-system:master.

@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 5, 2019
Closed
@fingolfin
Copy link
Member

Huh... why does TmpNameAllArchs even exist, though? Why isn't this code simply part of TmpName?

@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Mar 6, 2019
fingolfin
fingolfin approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I find TmpNameAllArchs highly suspicious, this is something for a separate discussion; as long as this change here fixes the test, let's merge it.

@fingolfin fingolfin merged commit bf37caf into gap-system:master Mar 6, 2019
@olexandr-konovalov olexandr-konovalov deleted the fix-streams-test branch March 6, 2019 10:22
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olexandr-konovalov @coveralls @fingolfin