Avoid GC problem in Cyclotomic #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
added
kind: bug: crash
fingolfin
approved these changes
Mar 27, 2018
| @@ -688,7 +688,9 @@ Obj Cyclotomic ( | |||
| res[0] = cof; | |||
| else { | |||
| CHANGED_BAG( ResultCyc ); | |||
| res[0] = DIFF( INTOBJ_INT(0), cof ); | |||
| Obj negcof = DIFF( INTOBJ_INT(0), cof ); | |||
There was a problem hiding this comment.
I am happy to merge this, though you might want to change this to Obj negcof = AInvInt(cof);.
There was a problem hiding this comment.
No I can't, because cof can be a rational :) (seperate note, some int related functions could produce more helpful errors when given non integres)
There was a problem hiding this comment.
Ah, sorry for the red herring
There was a problem hiding this comment.
(Actually, I have a déjà-vu ... didn't we discuss the exact same thing at the same spot before?)
ChrisJefferson
force-pushed
the
cyclotom-fix
branch
from
f9c947a to
e56c620
Compare
DIFF can cause a GC, which might move ResultCyc
ChrisJefferson
force-pushed
the
cyclotom-fix
branch
from
e56c620 to
702bc0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
==========================================
- Coverage 72.33% 72.31% -0.03%
==========================================
Files 479 479
Lines 250960 251946 +986
==========================================
+ Hits 181538 182185 +647
- Misses 69422 69761 +339
|
fingolfin
approved these changes
Mar 28, 2018
fingolfin
added
release notes: added
|
Backported to stable-4.9 as 01b3b13 |
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIFF can cause a GC, which might move ResultCyc
Found using 'memory canary'.
This should also be cherry-picked onto 4.9.