Fix issue #1258 #1259
Merged
Fix issue #1258 #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
- Coverage 60.64% 60.64% -0.01%
==========================================
Files 929 929
Lines 286196 286190 -6
Branches 16813 16813
==========================================
- Hits 173557 173548 -9
- Misses 108331 108332 +1
- Partials 4308 4310 +2
|
|
Cheers! |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for Issue #1258, based on the patch suggested by @fingolfin which takes a shallow copy of
wlistin theFMtoFSandFStoFMfunctions inIsomorphismFpSemigroup, to avoid a bug related to mutability.I've added tests which demonstrate the fix.