Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.01] Update more scripts to respect GALAXY_VIRTUAL_ENV. #1847

Merged

Conversation

jmchilton
Copy link
Member

Drop explicit sourcing in run_reports and run_tool_shed since they source common_startup.

Drop explicit sourcing in run_reports and run_tool_shed since they source common_startup.
@nsoranzo
Copy link
Member

nsoranzo commented Mar 3, 2016

👍

@nsoranzo
Copy link
Member

nsoranzo commented Mar 3, 2016

What happened to the Jenkins tests?

martenson added a commit that referenced this pull request Mar 3, 2016
[16.01] Update more scripts to respect GALAXY_VIRTUAL_ENV.
@martenson martenson merged commit 97793ab into galaxyproject:release_16.01 Mar 3, 2016
@natefoo
Copy link
Member

natefoo commented Mar 7, 2016

@jmchilton Nothing sources common_startup.sh, they call it. Thus, the environment used in common_startup.sh is not passed back to the calling script. I think the changes to run_reports.sh and run_tool_shed.sh need to be reverted.

@jmchilton
Copy link
Member Author

I'm out this week for spring break, but I'll try to find some time to fix this later this evening. Sorry.

@natefoo
Copy link
Member

natefoo commented Mar 7, 2016

Oh, no problem, I'll get it.

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Mar 8, 2016
afgane added a commit to afgane/galaxy that referenced this pull request Mar 9, 2016
natefoo added a commit that referenced this pull request Mar 15, 2016
[16.01] Fix virtual env handling broken with #1847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants