Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable metadata hash verification #853

Merged
merged 10 commits into from
Jul 15, 2024
Merged

feat: enable metadata hash verification #853

merged 10 commits into from
Jul 15, 2024

Conversation

@Roznovjak Roznovjak self-assigned this Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Crate versions that have been updated:

  • hydradx-runtime: v245.0.0 -> v246.0.0

Runtime version has been increased.

@bkchr
Copy link
Contributor

bkchr commented Jul 5, 2024

@Roznovjak how are you building the runtime? Why do you think that it did not set the env variable?

@Roznovjak
Copy link
Contributor Author

@Roznovjak how are you building the runtime? Why do you think that it did not set the env variable?

I'm building it with cargo build --release -p hydradx-runtime --features=metadata-hash.
After the build, echo $RUNTIME_METADATA_HASH is empty.

@bkchr
Copy link
Contributor

bkchr commented Jul 5, 2024

After the build, echo $RUNTIME_METADATA_HASH is empty.

The env variable is not only set for the wasm-builder in the build process. It will not be set afterwards.

@Roznovjak
Copy link
Contributor Author

After the build, echo $RUNTIME_METADATA_HASH is empty.

The env variable is not only set for the wasm-builder in the build process. It will not be set afterwards.

Ah. Thanks.

@Roznovjak Roznovjak marked this pull request as ready for review July 9, 2024 15:32
@Roznovjak Roznovjak merged commit 29f7568 into master Jul 15, 2024
5 checks passed
@Roznovjak Roznovjak deleted the metadata_hash branch July 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants