fix!: Patch XCM Executor #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hed polkadot version
|
Crate versions that have been updated:
Runtime version has been increased. |
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 81.21% 81.24% +0.02%
==========================================
Files 19 20 +1
Lines 1927 1930 +3
==========================================
+ Hits 1565 1568 +3
Misses 362 362
Continue to review full report at Codecov.
|
|
Task linked: CU-2rgt0pz Patch XCM executor |
enthusiastmartin
approved these changes
Jul 15, 2022
Co-authored-by: Martin Hloska <martin.hloska@gmail.com>
mrq1911
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a patched version of Polkadot that fixes the XCM executor to trap assets on failed instructions.
Description
This PR adds an integration test for asset trapping on receiving unknown assets and uses a patched Polkadot version that ensures the asset is trapped (and not burned).
Related Issue
Based on paritytech/polkadot@release-v0.9.17...apopiak:polkadot:apopiak/fix-xcm-executor-atomicity
Motivation and Context
Assets that are not recognized on
BuyExecution(and thus trigger an error) get burned in the XCMv2 executor.How Has This Been Tested?
Checklist: