feat: remove sudo #515
feat: remove sudo #515
Conversation
|
Runtime version has not been increased. |
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
==========================================
- Coverage 81.25% 81.21% -0.05%
==========================================
Files 19 19
Lines 1942 1927 -15
==========================================
- Hits 1578 1565 -13
+ Misses 364 362 -2
Continue to review full report at Codecov.
|
Which one? Most of the pallets are already configured |
ok, i'll review it case by case |
| @@ -737,8 +717,7 @@ impl pallet_tips::Config for Runtime { | |||
| impl pallet_collator_selection::Config for Runtime { | |||
| type Event = Event; | |||
| type Currency = Balances; | |||
| //allow 1/2 of council to execute privileged collator selection operations. (require code from: feat/initial_chain_setup) | |||
| type UpdateOrigin = EnsureMajorityCouncilOrRoot; | |||
| type UpdateOrigin = MajorityTechCommitteeOrRoot; | |||
There was a problem hiding this comment.
This has changed from council to committee.
Is it correct?
There was a problem hiding this comment.
yes, currently required to maintain stable running chain
| type ExecuteOverweightOrigin = EnsureRoot<AccountId>; | ||
| type ControllerOrigin = crate::EnsureMajorityCouncilOrRoot; | ||
| type ExecuteOverweightOrigin = MajorityTechCommitteeOrRoot; | ||
| type ControllerOrigin = MajorityTechCommitteeOrRoot; |
There was a problem hiding this comment.
Also here from council to comitte. Just making sure that it is conscious decision
There was a problem hiding this comment.
yes, these roles are more for sorting out technical issues
Sudo pallet was removed from basilisk runtime.
some root only actions shifted to the council and technical comitee