Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fee currency change #514

Merged
merged 3 commits into from
Jul 11, 2022
Merged

fix: fee currency change #514

merged 3 commits into from
Jul 11, 2022

Conversation

mrq1911
Copy link
Member

@mrq1911 mrq1911 commented Jul 10, 2022

fee currency should not change when account holds native currency already

related to the #454

@github-actions
Copy link

github-actions bot commented Jul 10, 2022

Crate versions that have not been updated:

  • runtime-integration-tests: v0.3.6
  • pallet-exchange: v5.3.7
  • pallet-exchange-benchmarking: v3.3.16
  • pallet-lbp: v4.4.6
  • pallet-xyk: v4.0.3
  • basilisk-runtime: v63.0.0
  • common-runtime: v1.10.0
  • testing-basilisk-runtime: v63.0.0

Runtime version has not been increased.

@mrq1911 mrq1911 marked this pull request as draft July 11, 2022 08:44
@mrq1911 mrq1911 marked this pull request as ready for review July 11, 2022 12:26
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #514 (c835c74) into master (e0d2161) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   81.21%   81.21%           
=======================================
  Files          19       19           
  Lines        1927     1927           
=======================================
  Hits         1565     1565           
  Misses        362      362           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d2161...c835c74. Read the comment docs.

@mrq1911 mrq1911 merged commit 814fde0 into master Jul 11, 2022
@jak-pan jak-pan deleted the fix-fee-change branch February 22, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants