Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make repay fee constant #307

Merged
merged 8 commits into from
Jan 16, 2022
Merged

feat: make repay fee constant #307

merged 8 commits into from
Jan 16, 2022

Conversation

Roznovjak
Copy link
Collaborator

Add repay_fee into constant metadata.
Fixes: #306

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

Crate versions that have been updated:

  • pallet-lbp: v4.1.2 -> v4.2.0

Runtime versions don't match.

Runtime version has not been increased.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #307 (05aadf1) into master (aec25f1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   81.71%   81.73%   +0.01%     
==========================================
  Files          21       21              
  Lines        2210     2212       +2     
==========================================
+ Hits         1806     1808       +2     
  Misses        404      404              
Impacted Files Coverage Δ
pallets/lbp/src/lib.rs 81.20% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec25f1...05aadf1. Read the comment docs.

Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test and bump version

@Roznovjak Roznovjak requested a review from mrq1911 January 14, 2022 00:05
@mrq1911 mrq1911 merged commit eaa3f27 into master Jan 16, 2022
@jak-pan jak-pan deleted the feat/repay_fee_const branch February 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LBP repay fee to constants
2 participants