refactor: NFT #283
refactor: NFT #283
Conversation
There was a problem hiding this comment.
- chore: upgrade to polkadot 0.9.15 #321
- use substrate uniques pallet instead of local copy
|
Please move events to |
done |
| verify { | ||
| assert_eq!(orml_nft::Pallet::<T>::classes(class_id).iter().count(), 1); | ||
| assert_eq!(UNQ::Pallet::<T>::class_owner(&T::NftClassId::from(CLASS_ID_0).into()), Some(caller)); |
There was a problem hiding this comment.
Is this the worst case? Is adding to full vec more expensive? > https://substrate.stackexchange.com/questions/88/is-there-a-limit-to-the-size-of-a-map-in-pallet-storage
There was a problem hiding this comment.
It is adding to a map, not to a vec. Testing adding stuff to a nearly full map might be an overkill. There should be another incentives to keep the map size reasonable, in this case there is a configurable bond to create a class that exists until the class is destroyed.
# Conflicts: # Cargo.lock # node/Cargo.toml
NFT pallet that provides basic generic interface to manipulate with NFTs
It is possible to directly call extrinsics from this pallet but also provides public interface (do_method) for pallets that are built on top of it.
tech spec: https://www.notion.so/NFT-Technical-specification-f387682d6ef34b6091f5607bfa912a19
REVIEW OF PALLET-UNIQUES IS NOT NEEDED
Note: NFT pallet has been migrated to wrap FRAME Uniques instead of ORML. Because there is a couple of slight customizations to Uniques, it was necessary to fork the pallet. There is a PR open already, hopefully it will get to substrate codebase soon enough so we can use the Uniques pallet natively.
paritytech/substrate#10529
Update 20211231: PR merged, waiting for release
Update 20220118: Can be used natively from v0.9.15
Update 20220204: Uniques fork removed and is used natively