Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exchange #216

Merged
merged 12 commits into from
Nov 9, 2021
Merged

fix: exchange #216

merged 12 commits into from
Nov 9, 2021

Conversation

Roznovjak
Copy link
Collaborator

@Roznovjak Roznovjak commented Oct 29, 2021

This PR fixes two issues in the Exchange pallet:

  • overflow of ExchangeAssetsIntentionCount
  • reservation of an amount which is not required for a trade

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #216 (833c1fe) into master (d312d7e) will increase coverage by 0.25%.
The diff coverage is 85.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   82.82%   83.08%   +0.25%     
==========================================
  Files          23       23              
  Lines        2108     2152      +44     
==========================================
+ Hits         1746     1788      +42     
- Misses        362      364       +2     
Impacted Files Coverage Δ
pallets/xyk/src/lib.rs 81.89% <ø> (ø)
pallets/exchange/src/direct.rs 85.88% <84.88%> (+3.24%) ⬆️
pallets/exchange/src/lib.rs 78.66% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668acf7...833c1fe. Read the comment docs.

@Roznovjak Roznovjak marked this pull request as ready for review October 30, 2021 13:51
Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to go through this together to understand better the reasoning.

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@Roznovjak Roznovjak merged commit 27be8c5 into master Nov 9, 2021
@Roznovjak Roznovjak deleted the fix/exchange branch November 15, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants