chore!: lbp refactor

[jak-pan]

• Remove unnecessary storage (last weight update, last weights)
• Remove unnecessary tuples
• Remove asset sorting - asset_a is now the asset you are selling (If conducting a sale)
• Changed weights to % of the asset_a in the pool
• Change weight
• Remove pause
• Consolidate functions
• Fix tests
• Fix docs
• Update math / extract types
• Fix readme

---

• Audit

[codecov]

Codecov Report

Merging #185 (117b941) into master (ae46540) will decrease coverage by 0.17%.
The diff coverage is 99.09%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   85.22%   85.04%   -0.18%     
==========================================
  Files          21       21              
  Lines        2132     2013     -119     
==========================================
- Hits         1817     1712     -105     
+ Misses        315      301      -14     

Impacted Files	Coverage Δ
pallets/lbp/src/lib.rs	87.84% <98.36%> (+1.84%)	⬆️
pallets/lbp/src/benchmarking.rs	100.00% <100.00%> (ø)
primitives/src/traits.rs	71.42% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae46540...117b941. Read the comment docs.

[Roznovjak]

The problem with the build is caused by LBP benchmarking tests. We are trying to perform a trade, but our LBP sale is not running. LBP uses RelaychainBlockNumberProvider, and it is used to fetch the current block number. The previous implementation used System::<T>::set_block_number() to change the current block number in the benchmarks, but it doesn't modify a block number fetched from the RelaychainBlockNumberProvider. I was able to "fix" the error and take advantage of the fact that the current block is set to 1 (and use a hacky way to set the start of LBP to block 1). But this "hack" doesn't work for benchmarking the remove_liquidity where we should call this method after the end of an LBP event. Any ideas what to do with this issue? :head_bandage:
To summarize the issue: we can't use System::<T>::set_block_number() in benchmarks to set the current block number

[Roznovjak]

The problem with the build is caused by LBP benchmarking tests. We are trying to perform a trade, but our LBP sale is not running. LBP uses RelaychainBlockNumberProvider, and it is used to fetch the current block number. The previous implementation used System::<T>::set_block_number() to change the current block number in the benchmarks, but it doesn't modify a block number fetched from the RelaychainBlockNumberProvider. I was able to "fix" the error and take advantage of the fact that the current block is set to 1 (and use a hacky way to set the start of LBP to block 1). But this "hack" doesn't work for benchmarking the remove_liquidity where we should call this method after the end of an LBP event. Any ideas what to do with this issue? :head_bandage: To summarize the issue: we can't use System::<T>::set_block_number() in benchmarks to set the current block number

I have looked at the implementation of the remove_liquidity method and calling it before the start of a sell and after the end of a sell should not have impact on the resulting weights.

[Roznovjak]

The following topics need to be resolved:

• do we allow reuse of a pool?
• fix benchmarks fix: LBP benchmarks #195

otherwise it LGTM

[Roznovjak]

I get this error in the UI. When the types are not enclosed in the types group, everything works ok. Is it supposed to work when the types are enclosed?

FATAL: Unable to initialize the API: createType(Lookup195):: DoNotConstruct: Cannot construct unknown type CurrencyIdOf