Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duster dependencies #153

Merged
merged 3 commits into from
Sep 3, 2021
Merged

fix: duster dependencies #153

merged 3 commits into from
Sep 3, 2021

Conversation

mrq1911
Copy link
Member

@mrq1911 mrq1911 commented Sep 2, 2021

No description provided.

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, it is ok.

I am not sure why it is needed because the dependencies which are moved from dev are needed only for tests.

They should not be really needed for release build ( imagine you want to use duster in an environment where there is not the basilisk primitives crate.

I'll will dig deeper.

@enthusiastmartin enthusiastmartin dismissed their stale review September 3, 2021 09:03

probably better solution

@galacticcouncil galacticcouncil deleted a comment from codecov bot Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #153 (c09cc6e) into master (55f8e7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files          21       21           
  Lines        2117     2117           
=======================================
  Hits         1824     1824           
  Misses        293      293           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f8e7d...c09cc6e. Read the comment docs.

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deps are back in dev-deps. So this is better solution to the issue.

@mrq1911 mrq1911 merged commit f4e23da into master Sep 3, 2021
@mrq1911 mrq1911 deleted the fix-duster-deps branch October 4, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants