Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix json configs to work with latest polkadot-launch #139

Merged
merged 5 commits into from
Aug 29, 2021

Conversation

enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Aug 27, 2021

It seems that polkadot-launch requires simpleParachains to be present in the configs.

Let's see. It should fix the inclusion test.

@enthusiastmartin
Copy link
Contributor Author

Now it runs but fails due some missing types ?!

@galacticcouncil galacticcouncil deleted a comment from codecov bot Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #139 (48a4f3b) into master (b13df01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files          21       21           
  Lines        2091     2091           
=======================================
  Hits         1798     1798           
  Misses        293      293           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13df01...48a4f3b. Read the comment docs.

@mrq1911 mrq1911 merged commit ec06971 into master Aug 29, 2021
@mrq1911 mrq1911 deleted the fix/para-configs branch October 4, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants