Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asset registry refactored #124

Merged
merged 34 commits into from
Aug 25, 2021
Merged

feat: asset registry refactored #124

merged 34 commits into from
Aug 25, 2021

Conversation

enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Aug 6, 2021

New pallet-registry added.

It is a rework of original and very simple asset-registry pallet. This new implementation attempts to be more robust and easier to use.

New Features compared to previous implementation includes:

  • dispatchables for registering and updating assets
  • string limit for asset name
  • native locations ( use for xcm ) - it possible to store an origin location of an asset. This can be used in xcm currency/location conversions ( no need to specify/hard-code it in runtime)
  • asset detail and metadata
  • better handling of 'next asset id' - our asset registry uses sequential ids which is assigned for each newly registered asset.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #124 (c911440) into master (a6db44f) will increase coverage by 0.42%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   85.66%   86.08%   +0.42%     
==========================================
  Files          20       21       +1     
  Lines        1911     2048     +137     
==========================================
+ Hits         1637     1763     +126     
- Misses        274      285      +11     
Impacted Files Coverage Δ
primitives/src/traits.rs 71.42% <50.00%> (-28.58%) ⬇️
pallets/asset-registry/src/lib.rs 88.67% <87.87%> (+12.48%) ⬆️
pallets/asset-registry/src/benchmarking.rs 100.00% <100.00%> (ø)
pallets/xyk/src/lib.rs 83.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6db44f...c911440. Read the comment docs.

@enthusiastmartin enthusiastmartin marked this pull request as ready for review August 10, 2021 07:21
@enthusiastmartin enthusiastmartin linked an issue Aug 12, 2021 that may be closed by this pull request
enthusiastmartin and others added 3 commits August 12, 2021 17:08
Co-authored-by: green-jay <75261756+green-jay@users.noreply.github.com>
Co-authored-by: green-jay <75261756+green-jay@users.noreply.github.com>
pallets/registry/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrq1911 mrq1911 merged commit c75cac6 into master Aug 25, 2021
@mrq1911 mrq1911 deleted the feat/asset-registry branch October 4, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve asset registry
4 participants