Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duster pallet #104

Merged
merged 16 commits into from
Aug 10, 2021
Merged

feat: duster pallet #104

merged 16 commits into from
Aug 10, 2021

Conversation

enthusiastmartin
Copy link
Contributor

Added duster and offchain duster pallets.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #104 (8b0131d) into master (f088a91) will decrease coverage by 1.42%.
The diff coverage is 59.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   87.08%   85.66%   -1.43%     
==========================================
  Files          17       20       +3     
  Lines        1812     1911      +99     
==========================================
+ Hits         1578     1637      +59     
- Misses        234      274      +40     
Impacted Files Coverage Δ
pallets/offchain-duster/src/lib.rs 0.00% <0.00%> (ø)
pallets/duster/src/lib.rs 88.67% <88.67%> (ø)
pallets/duster/src/benchmarking.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f088a91...8b0131d. Read the comment docs.

// Ignore the result, it fails - no problem.
let _ = Self::reward_duster(&who, currency_id, dust);

Ok(().into())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to refund the fees if the dusting was successful. That way you can maybe get away with a smaller reward.

@enthusiastmartin enthusiastmartin merged commit 6f1deb9 into master Aug 10, 2021
@enthusiastmartin enthusiastmartin deleted the feat/duster branch August 10, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants