Refactor client composition logic and remove unnecessary Toggl flag #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a major refactor on how the client composition is done and simplify client logic. Besides that, this commit reduces the duplicated logic across clients and outsources the authentication setter. Additionally, it makes it easier to integrate new clients with more complex authentication methods, like Oauth2. Also, the commit contains a change that removes the illogical flag for setting toggl client base URL, hence that never changes.
boring-cyborg
bot
added
clockify
![codeclimate[bot]](/~https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 41398f5 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 91.8% (75% is the threshold). This pull request will bring the total coverage in the repository to 78.8% (0.5% change). View more on Code Climate. |
gabor-boros
added a commit
that referenced
this pull request
Oct 23, 2021
…l flag (#30) * refactor: create Entries type * refactor(tempo): use new Entries type and inline entry group upload * refactor: add date time helpers * refactor: reorganize client composition Do a major refactor on how the client composition is done and simplify client logic. Besides that, this commit reduces the duplicated logic across clients and outsources the authentication setter. Additionally, it makes it easier to integrate new clients with more complex authentication methods, like Oauth2. Also, the commit contains a change that removes the illogical flag for setting toggl client base URL, hence that never changes.
gabor-boros
added a commit
that referenced
this pull request
Oct 23, 2021
…l flag (#30) * refactor: create Entries type * refactor(tempo): use new Entries type and inline entry group upload * refactor: add date time helpers * refactor: reorganize client composition Do a major refactor on how the client composition is done and simplify client logic. Besides that, this commit reduces the duplicated logic across clients and outsources the authentication setter. Additionally, it makes it easier to integrate new clients with more complex authentication methods, like Oauth2. Also, the commit contains a change that removes the illogical flag for setting toggl client base URL, hence that never changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a major refactor on how the client composition is done and simplify client logic. Besides that, this commit reduces the duplicated logic across clients and outsources the authentication setter.
Additionally, it makes it easier to integrate new clients with more complex authentication methods, like Oauth2.
Also, the commit contains a change that removes the illogical flag for setting Toggl Track client base URL, hence that never changes.
Supporting information
N/A
Dependencies
N/A
Screenshots
N/A
Testing instructions
Other information
This PR is kind of a requirement for integrating Zoho Books and other targets later on.
Checklist