feat: add initial Toggl Track integration #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](/~https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return entries, nil | ||
| } | ||
|
|
||
| func (c *togglClient) FetchEntries(ctx context.Context, opts *client.FetchOpts) ([]worklog.Entry, error) { |
There was a problem hiding this comment.
Method togglClient.FetchEntries has 6 return statements (exceeds 4 allowed).
| UnbillableDuration: unbillableDuration, | ||
| } | ||
|
|
||
| if c.opts.TagsAsTasks && len(fetchedEntry.Tags) > 0 { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit c647b7f and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 89.1% (75% is the threshold). This pull request will bring the total coverage in the repository to 78.8% (2.2% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #3 by implementing the initial Toggl Track integration.
Supporting information
The integration uses the reports API.
No precise start and end date filtering is accepted by Toggl Track report API that is used for this source, therefore only ISO 8601 (
YYYY-MM-DD) date format can be used. In Go, it is translated to2006-01-02when settingdate-formatin config or flags.Dependencies
N/A
Screenshots
N/A
Testing instructions
Other information
This PR includes some refactoring around splitting entries by tags -- entry splitting is now unified.
Checklist