Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build suddenly breaking on "angular-moment" not found #149

Closed
guy-mograbi-at-gigaspaces opened this issue Sep 1, 2015 · 4 comments
Closed

Comments

@guy-mograbi-at-gigaspaces

seems that 10 days ago, a dependency was added as a patch version.
this breaks backwards compatibility.

@eralha
Copy link
Collaborator

eralha commented Sep 1, 2015

You sugest remove that dependency?

@astik
Copy link
Contributor

astik commented Sep 26, 2015

If backward compatibility is broken, the version number should reflect that change.
As latest version upgrade were patches (x.x.y to x.x.y+1), compatibility should be preserved.
2 actions to do :

  • in the current 1.0.x branch : remove the angular-moment dependency
  • if angular-moment is the future of angular-datepicker, create a 1.1.0 version.

@astik
Copy link
Contributor

astik commented Sep 26, 2015

Change was introduced in 1.0.13. Project is now in 1.0.16 ... seems kinda difficult to rollback all changes =/

@eralha
Copy link
Collaborator

eralha commented Sep 28, 2015

Moment removed from dependencies.

@eralha eralha closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants